Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

wants to merge 1 commit into from
+16 −8

Conversation

DrFaust92
Copy link
Contributor

Closes #2196

@DrFaust92
fix cgroup all
ea7b85b 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 requested review from ericyz and a team as code owners December 21, 2024 21:15
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Dec 23, 2024
@apeabody
Copy link
Collaborator 

TestNodePool 2024-12-23T18:03:29Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 
Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-01"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-05"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-03"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-02"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-04"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.}
    apply.go:34: 
        	Error Trace:	/builder/home/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:34
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:571
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:630
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-01"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-05"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-03"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-02"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-04"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.}
        	Test:       	TestNodePool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_pools_cgroup_mode var does not correctly handle the "all" map key
2 participants
@DrFaust92 @apeabody